Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault tests #749

Merged
merged 19 commits into from
May 21, 2024
Merged

Vault tests #749

merged 19 commits into from
May 21, 2024

Conversation

fabianburth
Copy link
Contributor

@fabianburth fabianburth commented Apr 26, 2024

Description

Implement integration tests with vault.

It also fixes a bug where getting the credentials for a consumer provider lead to a deadlock or potentially an infinite recursion since we attempt to retrieve credentials to access the credential provider from the credential provider itself.

We might want to discuss the naming of the make targets. Thus, should make test run all tests including integration? Or should make test only run unit tests and make test-all (this is how I currently introduced it here) include integration tests?
Also, is it important that we have a make target which can run the integration tests exclusively (without including the unit tests)? This would require adding build tags to all tests.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🎇 Restructuring
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@hilmarf hilmarf added this to the 2024-Q2 milestone Apr 26, 2024
@fabianburth fabianburth marked this pull request as ready for review May 21, 2024 09:16
@fabianburth fabianburth requested a review from mandelsoft May 21, 2024 11:14
@fabianburth fabianburth enabled auto-merge (squash) May 21, 2024 11:16
@fabianburth fabianburth merged commit 93c6bad into open-component-model:main May 21, 2024
14 checks passed
@fabianburth fabianburth deleted the vault-tests branch May 21, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

3 participants