-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vault tests #749
Merged
fabianburth
merged 19 commits into
open-component-model:main
from
fabianburth:vault-tests
May 21, 2024
Merged
Vault tests #749
fabianburth
merged 19 commits into
open-component-model:main
from
fabianburth:vault-tests
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandelsoft
approved these changes
May 21, 2024
Installing Vault and an OCI Registry with the Makefile allows to write integration tests against those systems.
…credential providers
The credential cache is only written into the provider if the update succeeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement integration tests with vault.
It also fixes a bug where getting the credentials for a consumer provider lead to a deadlock or potentially an infinite recursion since we attempt to retrieve credentials to access the credential provider from the credential provider itself.
We might want to discuss the naming of the make targets. Thus, should
make test
run all tests including integration? Or shouldmake test
only run unit tests andmake test-all
(this is how I currently introduced it here) include integration tests?Also, is it important that we have a make target which can run the integration tests exclusively (without including the unit tests)? This would require adding build tags to all tests.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: